From 3ca248181d70227c85e8f3026524c8f6a9d30bb9 Mon Sep 17 00:00:00 2001
From: n4ze3m <n4ze3m@gmail.com>
Date: Sat, 8 Feb 2025 23:23:56 +0530
Subject: [PATCH] feat: make keepAlive property optional and remove default
 value assignment

---
 src/models/ChatOllama.ts       |  6 ++++--
 src/models/OllamaEmbedding.ts  |  2 +-
 src/services/model-settings.ts | 12 ++++++------
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/models/ChatOllama.ts b/src/models/ChatOllama.ts
index 18d18eb..f04aab2 100644
--- a/src/models/ChatOllama.ts
+++ b/src/models/ChatOllama.ts
@@ -37,7 +37,9 @@ export class ChatOllama
 
     baseUrl = "http://localhost:11434";
 
-    keepAlive = "5m";
+    // keepAlive = "5m";
+
+    keepAlive?: string;
 
     embeddingOnly?: boolean;
 
@@ -117,7 +119,7 @@ export class ChatOllama
         this.baseUrl = fields.baseUrl?.endsWith("/")
             ? fields.baseUrl.slice(0, -1)
             : fields.baseUrl ?? this.baseUrl;
-        this.keepAlive = parseKeepAlive(fields.keepAlive) ?? this.keepAlive;
+        this.keepAlive = parseKeepAlive(fields.keepAlive);
         this.embeddingOnly = fields.embeddingOnly;
         this.f16KV = fields.f16KV;
         this.frequencyPenalty = fields.frequencyPenalty;
diff --git a/src/models/OllamaEmbedding.ts b/src/models/OllamaEmbedding.ts
index b0395c3..feefd38 100644
--- a/src/models/OllamaEmbedding.ts
+++ b/src/models/OllamaEmbedding.ts
@@ -118,7 +118,7 @@ export class OllamaEmbeddingsPageAssist extends Embeddings {
 
   headers?: Record<string, string>
 
-  keepAlive = "5m"
+  keepAlive?: string
 
   requestOptions?: OllamaRequestParams["options"]
 
diff --git a/src/services/model-settings.ts b/src/services/model-settings.ts
index 82afca7..4ede24e 100644
--- a/src/services/model-settings.ts
+++ b/src/services/model-settings.ts
@@ -75,9 +75,9 @@ export const getAllModelSettings = async () => {
     for (const key of keys) {
       const value = await storage.get(key)
       settings[key] = value
-      if (!value && key === "keepAlive") {
-        settings[key] = "5m"
-      }
+      // if (!value && key === "keepAlive") {
+      //   settings[key] = "5m"
+      // }
     }
     return settings
   } catch (error) {
@@ -98,9 +98,9 @@ export const getAllDefaultModelSettings = async (): Promise<ModelSettings> => {
   for (const key of keys) {
     const value = await storage.get(key)
     settings[key] = value
-    if (!value && key === "keepAlive") {
-      settings[key] = "5m"
-    }
+    // if (!value && key === "keepAlive") {
+    //   settings[key] = "5m"
+    // }
   }
   return settings
 }